Rust: Rework type inference for method calls #20282
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
hvitved
force-pushed
the
rust/type-inference-method-call-resolution-rework
branch
2 times, most recently
from
e4cfb86 to
4a8c37c
Compare
| @@ -1087,10 +1094,11 @@ | |||
| * For example, if this access is the method call `M(42)`, then the inferred | |||
| * type at argument position `0` is `int`. | |||
| */ | |||
| Type getInferredType(AccessPosition apos, TypePath path); | |||
| bindingset[state] | |||
Check warning
Code scanning / CodeQL
Missing QLDoc for parameter Warning
hvitved
force-pushed
the
rust/type-inference-method-call-resolution-rework
branch
from
4a8c37c to
e75d79e
Compare
|
|
||
| /** | ||
| * Holds if `constraint` might occur as the third argument of | ||
| * `potentialInstantiationOf`. Defaults to simply projecting the third | ||
| * argument of `potentialInstantiationOf`. | ||
| */ | ||
| default predicate relevantTypeMention(TypeMention tm) { potentialInstantiationOf(_, _, tm) } | ||
| default predicate relevantTypeMention(Constraint tm) { potentialInstantiationOf(_, _, tm) } |
Check warning
Code scanning / CodeQL
Missing QLDoc for parameter Warning
hvitved
force-pushed
the
rust/type-inference-method-call-resolution-rework
branch
8 times, most recently
from
61866bf to
2d1ed65
Compare
hvitved
force-pushed
the
rust/type-inference-method-call-resolution-rework
branch
from
2d1ed65 to
3d19a06
Compare
hvitved
force-pushed
the
rust/type-inference-method-call-resolution-rework
branch
from
3d19a06 to
153c10b
Compare
hvitved
force-pushed
the
rust/type-inference-method-call-resolution-rework
branch
from
153c10b to
e161d4c
Compare
hvitved
force-pushed
the
rust/type-inference-method-call-resolution-rework
branch
from
dd45f7b to
a20c440
Compare
hvitved
force-pushed
the
rust/type-inference-method-call-resolution-rework
branch
4 times, most recently
from
06a8539 to
7a7a127
Compare
hvitved
force-pushed
the
rust/type-inference-method-call-resolution-rework
branch
from
f45d2d5 to
f9f8782
Compare
| * `self5` | `impl T2 for X` | `X` | ||
| */ | ||
| private class SelfParamType extends TSelfParamType { | ||
| private predicate asSelfParam(Function f, FunctionPosition pos, ImplOrTraitItemNode i) { |
Check warning
Code scanning / CodeQL
Predicates starting with "get" or "as" should return a value Warning
|
|
||
| pragma[nomagic] | ||
| abstract Type getParameterType(DeclarationPosition dpos, TypePath path); | ||
| private predicate asInheritedSelfParam( |
Check warning
Code scanning / CodeQL
Predicates starting with "get" or "as" should return a value Warning
| pragma[nomagic] | ||
| private Type inferMethodCallExprType(AstNode n, TypePath path) { | ||
| exists( | ||
| MethodCallMatchingInput::Access a, MethodCallMatchingInput::AccessPosition apos, string state, |
Check warning
Code scanning / CodeQL
Omittable 'exists' variable Warning
| | | ||
| functionResolutionDependsOnArgument(impl, _, result, pos, _, _) | ||
| or | ||
| exists(TypeParameter tp | traitTypeParameterOccurrence(trait, resolved, _, pos, _, tp) | |
Check warning
Code scanning / CodeQL
Omittable 'exists' variable Warning
| */ | ||
| // pragma[nomagic] | ||
| pragma[inline] | ||
| private predicate methodCandidateTrait( |
Check warning
Code scanning / CodeQL
Missing QLDoc for parameter Warning
No description provided.